Run CI against Django main branch
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought, it make sense to be ready and see possible issues upfront. This practice is ofthen used by OSS Django packages, for example, check out: https://github.com/jazzband/
|
@amureki your pull request is missing a changelog! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought, it makes sense to be ready and see possible issues upfront.
This practice is often used by OSS Django packages, for example, check out: https://github.com/jazzband/
Update - it works!
https://github.com/model-bakers/model_bakery/pull/159/checks?check_run_id=2069745846
See, some tests in Python 3.9 Django
mainjob failed, however, this did not affect the final outcome, as we are not promising support for dev versions. However, now we can start some work on fixing these issues. ✨